Fix parsing of low-sample-rate MP3 files. #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192.
Another bug in JUCE's
MP3AudioFormat: when reading MP3 files, some files with low sample rates have their durations incorrectly estimated. Reading frames from these files works just fine, but Pedalboard reports that they're longer than they actually are, resulting inRuntimeErrors when trying to read thef.frames.This PR fixes the issue by properly implementing the part of the MP3 spec that specifies the number of samples per MP3 frame:
The parser is also changed slightly to not throw an error if the stream runs out of MP3 frames while parsing is still in progress, but instead to pad the end of the stream (from
f.tell()throughf.frames) with zeroes, as is the convention in JUCE.